search

openwallet-foundation / acapy

ACA-Py is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://aca-py.org
Apache License 2.0
420 stars 513 forks source link

default_version_upgrade_config.yml file missing from aca-py release #2178

Closed ianco closed 1 year ago

ianco commented 1 year ago

default_version_upgrade_config.yml is missing from aca-py python release - this file is required to run the aca-py upgrade command.

See this issue: https://github.com/bcgov/openshift-aries-mediator-service/issues/25

swcurran commented 1 year ago

Is this the before or after version? E.g. should that be set to 0.8.0, or did it need to exist for prior versions?

The naming on these things is hard to interpret.

swcurran commented 1 year ago

And where should the file be?

WadeBarnes commented 1 year ago

The file is in the correct location and contains the correct content. It just needs to be included in the release.

I did find it strange that you can only specify versions that are explicitly listed in the config file and that when upgrading to v0.8.0 you have to specify --from-version=v0.8.0 rather than indicating the version you're actually upgrading from.

swcurran commented 1 year ago

I’m confused by the “included in the release”? Do you mean has not been tagged in the release, or do you mean the container image artifact does not include it? Or something else? Also, when doing the release, I didn’t update the file. Should it be updated each release?

WadeBarnes commented 1 year ago

The file exists in the source code; https://github.com/hyperledger/aries-cloudagent-python/tree/main/aries_cloudagent/commands

But is not included in the PyPi distributions; https://github.com/bcgov/openshift-aries-mediator-service/issues/25#issuecomment-1481453249

and therefore is not installed on the images.

swcurran commented 1 year ago

OK — some somewhere there is a manifest of things to include in the PyPi release. I’ll see what I can figure out.

swcurran commented 1 year ago

But that means we need to do a 0.8.1 immediately, right?

WadeBarnes commented 1 year ago

I think so. Anyone trying to run the upgrade will run into this issue.

swcurran commented 1 year ago

I can’t see how to add it to the package. AFAIK, the PyPi release should pickup everything in aries_cloudagent, which should include that file.

@ianco — if you know what update is needed, please do it. If not, I’ll get someone else to investigate. I’m assuming this is trivial.