jleach commented 1 month ago

Summary of Changes

Reuse a connection if that connection already exists. Otherwise, create a new connection.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 51.42857% with 17 lines in your changes missing coverage. Please review.

Project coverage is 57.14%. Comparing base (f475eed) to head (79d642b). Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/legacy/core/App/screens/Scan.tsx	38.46%	16 Missing :warning:
packages/legacy/core/App/utils/helpers.ts	88.88%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1285 +/- ## ========================================== + Coverage 57.12% 57.14% +0.02% ========================================== Files 204 204 Lines 6980 7017 +37 Branches 1978 1987 +9 ========================================== + Hits 3987 4010 +23 - Misses 2971 2985 +14 Partials 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.