openwallet-foundation / bifold-wallet

Aries Mobile Agent React Native - Part of the Aries Bifold effort to provide SSI capabilities in a production ready app.
Apache License 2.0
154 stars 150 forks source link

ui: fix visual and bug on removing contact #1302

Closed fc-santos closed 3 weeks ago

fc-santos commented 3 weeks ago

Summary of Changes

This PR changes the visual of the default ContactCredentialListItem in the ContactDetails Screen and the look of the contact name + logo.

Contact without Image:

image

Contact with image:

image

For consistence, I have also added an Icon for 'Remove from wallet':

image

This PR also fixes a problem with the removal of the contact when it has issued credentials.

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

PR template adapted from the Python attrs project.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bryce-mcmath commented 3 weeks ago

@fc-santos what part of this PR addresses this:

This PR also fixes a problem with the removal of the contact when it has issued credentials.

Just curious, it's not super obvious to me

fc-santos commented 3 weeks ago

@bryce-mcmath The new hook useBranding(params) was being used in the ContactCredentialListItem and the params being passed was not being memoized and it was causing an infinite re-render.