openwallet-foundation / credential-format-comparison-sig

Information about available credential formats
https://openwallet-foundation.github.io/credential-format-comparison-sig/
Creative Commons Attribution 4.0 International
10 stars 11 forks source link

BUG: checkout on windows system throws an error #54

Closed cre8 closed 10 months ago

cre8 commented 11 months ago

When cloning the repository on windows I get this error:

remote: Enumerating objects: 695, done.
remote: Counting objects: 100% (245/245), done.
remote: Compressing objects: 100% (78/78), done.
remote: Total 695 (delta 193), reused 170 (delta 166), pack-reused 450
Receiving objects: 100% (695/695), 357.70 KiB | 1.00 MiB/s, done.
Resolving deltas: 100% (452/452), done.
error: invalid path 'data/Key-Management/did:ebsi.json'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

According to the docs the : is not allowed in the filepath: https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file

Renaming the files should solve the problem since the name of the key management is defined inside the json file and not by the file name. Maybe we should also add a check in the cicd that is validating has a valid name for windows users