fix: remove key id - Githubissues

openwallet-foundation / credo-ts

Typescript framework for building decentralized identity and verifiable credential solutions

https://credo.js.org

Apache License 2.0

276 stars 202 forks source link

fix: remove key id #1971

Closed berendsliedrecht closed 4 months ago

berendsliedrecht commented 4 months ago

Had to remove the keyId property on the Key class as it was not ready yet. It caused some issues as some places we just infer the key id as the publicKeyBase58 and because of that, some keys with a custom would not work.
It is not required for the hardware key as the key id for the record is the publicKeyBase58, but for the underlying hardware key in the secure element it will just be a UUID.

When we do a bigger crypto move I would like to bring the custom key id back.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: b1aeac6392f7665be2700ef8ea1ddb8f9afaae59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR