Example refinements - Githubissues

openwallet-foundation / owl-akrida

Apache License 2.0

3 stars 16 forks source link

Example refinements #21

Closed KimEbert42 closed 11 months ago

KimEbert42 commented 1 year ago

[ ] Example instance-configs uses holder-db for aca-py database name. It should be issuer-db.

See https://github.com/hyperledger/aries-akrida/blob/264270c95c19974ca5f242f9ceed644d998c1687/instance-configs/database/docker-compose.yml#L3

[ ] The mediator configuration should point to the dockerfile and build the image

https://github.com/hyperledger/aries-akrida/blob/264270c95c19974ca5f242f9ceed644d998c1687/instance-configs/mediator/docker-compose.yml#L4

[ ] Mediator configuration should use a .env file to manage variables.

KimEbert42 commented 11 months ago

These issues were solved in #25