search

openwallet-foundation / owl-akrida

Apache License 2.0
3 stars 16 forks source link

Use verifier agent and config for verifier tests #45

Closed loneil closed 9 months ago

loneil commented 9 months ago

For the BCGov verification use cases we are using a Traction agent (just a multitenant ACA-Py really) for issuing and verifying as is done in the existing locustMediatorPresentProof test. (I'm creating my own test script that's not committed here but essentially same steps as locustMediatorPresentProof.py)

I'm seeing that

  1. The test invokes the issuer client to get the invite in the get_verifier_invite step
  2. In the verifier agent web requests load-agent/verifierAgent/acapy.py it is using the ISSUER* environment values instead of the VERIFIER* ones.

I'm not sure if using a same issuer agent is the intent here? But it seems it should be using the configured verifier agent in this case instead (if that is to be the same agent as the issuer I think it could just be that the test operator sets the verifier config to the same url/headers as the issuer one).

I've confirmed our tests that we are developing running with the changes contained in this PR.

swcurran commented 9 months ago

Thanks — I wondered about that. I ran test with a verifier and realized that I hadn’t gotten the auth token for the verifier, but the test worked! I figured it was using the issuer, but didn’t get back to it to confirm or fix.

@reflectivedevelopment @anwalker293 — looks like there are a few PRs along with this one to be reviewed and possibly merged — could you please take a look? Thanks!

anwalker293 commented 9 months ago

This looks good to me. @reflectivedevelopment and I talked about this a bit a while ago.

I'm curious about the most effective method on implementing this when the issuer and verifier are the same agent...

Certainly, this can be a separate PR, but I'm not sure the best way to go about this... thoughts?

anwalker293 commented 9 months ago

(Let's wait to merge until we get feedback from Kim though. I think we had a conversation about something not being cleaned up properly / we did in fact put everything in terms of the ISSUER variable assuming the ISSUER and VERIFIER were the same agent, but it's been a while since we had this conversation.)

swcurran commented 9 months ago

If we have a separately configurable issuer and verifier, you can use them for separate agents, or use one agent by setting both sets of env variables for the url and auth token to the same values. Makes it easy to use one or two agents.

anwalker293 commented 9 months ago

Kim gave me a verbal thumbs up, going to go ahead and merge - will probably have to worry about this more later with respect to the cleaning up at end of tests PR