search

openweave / openweave-core

openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging.
Apache License 2.0
233 stars 105 forks source link

Package Moved config.guess But Did Not Update All Dependent Build Infrastructure #651

Closed gerickson closed 3 years ago

gerickson commented 3 years ago

At some point, config.guess was moved from it's historical home at third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess to third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess; however, the dependent content was not updated to reflect this change:

% git grep 'config.guess' src/ doc/ build/ Makefile*
Makefile-Android:--build=$(shell $(AbsTopSourceDir)/third_party/nlbuild-autotools/repo/autoconf/config.guess) \
Makefile-Standalone:TargetTuple                     = $(shell ${AbsTopSourceDir}/third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess | sed -e 's/[[:digit:].]*$$//g')
Makefile-iOS:--build=$(shell $(AbsTopSourceDir)/third_party/nlbuild-autotools/repo/autoconf/config.guess) \
build/efr32/efr32-openweave.mk:OPENWEAVE_BUILD_ARCH = $(shell $(OPENWEAVE_ROOT)/third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess | sed -e 's/[[:digit:].]*$$//g')
build/esp32/components/openweave/component.mk:BUILD_ARCH                  := $(shell $(OPENWEAVE_ROOT)/third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess | sed -e 's/[[:digit:].]*$$//g')
build/nrf5/nrf5-openweave.mk:OPENWEAVE_BUILD_ARCH = $(shell $(OPENWEAVE_ROOT)/third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess | sed -e 's/[[:digit:].]*$$//g')
src/test-apps/TestWeaveDeviceMangerJNI:BUILD_TARGET_DIR=`${OPENWEAVE_ROOT}/third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess`
src/test-apps/TestWeaveTool.py:        configGuessTool = os.path.join(args.weaveRoot, './third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess')
src/test-apps/run-security-support-test.sh:    BUILD_TARGET=`${WEAVE_ROOT_DIR}/third_party/nlbuild-autotools/repo/third_party/autoconf/config.guess | sed -e 's/[[:digit:].]*$$//g'`

Consequently, invoking make -f Makefile-Android fails with:

make: /Users/gerickson/Source/github.com/openweave/openweave-core//third_party/nlbuild-autotools/repo/autoconf/config.guess: Command not found