search

openweave / openweave-core

openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging.
Apache License 2.0
233 stars 105 forks source link

Openweave Python packages should not depend on Python ABI version #658

Closed abalawender closed 3 years ago

abalawender commented 3 years ago

We've noticed that Openweave Python packages on PyPI are only uploaded for specific Python versions. This was a problem when we switched from Python 3.7 to Python 3.8, and it was finally solved by uploading a new Python package to PyPI. But now we've switched to Python 3.9 and the problem surfaced again... so it's high time we find a better solution.

Since Openweave Python package includes, and wraps around, a binary shared object, it is not a "pure" package. However, in that case, Python's "wheel" packer assumes the package uses Python ABI (e.g. it builds a Python module as a shared object), and tags it with the version of ABI and the interpreter. Openweave does not use Python ABI, so this is an unnecessary constraint. This PR removes it.

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

abalawender commented 3 years ago

@googlebot I fixed it.

google-cla[bot] commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

abalawender commented 3 years ago

3rd attempt to get the spuriously failing test to pass.

abalawender commented 3 years ago

4th attempt to get happy/tests/standalone/tunnel/test_weave_tunnel_02.py to pass.