search

openweave / openweave-core

openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging.
Apache License 2.0
233 stars 105 forks source link

Retain TCPEndPoint upon TCP repair #659

Closed pidarped closed 3 years ago

pidarped commented 3 years ago

Also, remove redundant call to ServiceMgr->cancel() when closing a repaired connection.

codecov-io commented 3 years ago

Codecov Report

Merging #659 (9939e23) into master (6263730) will decrease coverage by 0.00%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
- Coverage   70.09%   70.08%   -0.01%     
==========================================
  Files         484      484              
  Lines       87454    87454              
==========================================
- Hits        61302    61295       -7     
- Misses      26152    26159       +7
Impacted Files Coverage Δ
src/inet/TCPEndPoint.cpp 51.32% <ø> (ø)
...files/weave-tunneling/WeaveTunnelConnectionMgr.cpp 77.41% <50.00%> (ø)
src/lib/profiles/time/WeaveTimeCoordinator.cpp 94.11% <0.00%> (-5.89%) :arrow_down:
src/lib/profiles/time/WeaveTimeServer.cpp 91.13% <0.00%> (-0.50%) :arrow_down:
src/lib/profiles/time/WeaveTimeClient.cpp 59.47% <0.00%> (-0.39%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6263730...9939e23. Read the comment docs.