search

openweave / openweave-core

openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging.
Apache License 2.0
233 stars 105 forks source link

Move SetProtocolLayerCallback from InitiateSubscription to _prepareBinding #665

Closed didishe90 closed 3 years ago

didishe90 commented 3 years ago

Make double sure the protocol callback is set on the binding object.

codecov-commenter commented 3 years ago

Codecov Report

Merging #665 (68a2d2d) into master (dec54fd) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   70.07%   70.09%   +0.02%     
==========================================
  Files         486      486              
  Lines       87459    87459              
==========================================
+ Hits        61286    61304      +18     
+ Misses      26173    26155      -18
Impacted Files Coverage Δ
...les/data-management/Current/SubscriptionClient.cpp 84.58% <100.00%> (+0.28%) :arrow_up:
src/lib/support/ASN1Writer.cpp 86.52% <0.00%> (-0.87%) :arrow_down:
src/lib/profiles/security/WeaveToX509.cpp 87.91% <0.00%> (-0.26%) :arrow_down:
src/lib/profiles/security/WeaveCASEEngine.cpp 92.57% <0.00%> (-0.24%) :arrow_down:
src/test-apps/TestCASE.cpp 95.89% <0.00%> (-0.23%) :arrow_down:
src/lib/core/WeaveFabricState.cpp 59.76% <0.00%> (+0.11%) :arrow_up:
src/test-apps/ToolCommon.cpp 57.84% <0.00%> (+0.31%) :arrow_up:
src/inet/TCPEndPoint.cpp 51.09% <0.00%> (+0.34%) :arrow_up:
src/lib/profiles/time/WeaveTimeClient.cpp 59.86% <0.00%> (+0.38%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dec54fd...68a2d2d. Read the comment docs.