search

openweave / openweave-core

openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging.
Apache License 2.0
233 stars 105 forks source link

Add NULL-check for `MessageLayer->FabricState` on connection close. #674

Closed lcniles closed 3 years ago

lcniles commented 3 years ago

https://crash.corp.google.com/browse?q=stable_signature%3D%27nl%3A%3AWeave%3A%3AWeaveConnection%3A%3ADoClose-24bb06ea%27

robszewczyk commented 3 years ago

The only concern I have with this patch is that it could end up masking a deeper problem. IIRC the code was vetted at some point to convince ourselves that the NULL checks were in place where needed and somehow we believed that the null check was not necessary here. But I can think about this offline, while we reap the benefits of this patch