search

openwrt / actions-shared-workflows

4 stars 12 forks source link

RFC: Try to prevent harder buildbot failures #5

Open ynezz opened 6 months ago

ynezz commented 6 months ago

Merging pull request https://github.com/openwrt/openwrt/pull/14218 (with all 190 CI checks green) resulted in buildbot failures in Kernel/CollectDebug step, likely due to the fact, that CI builds don't use same config options as on buildbot, specifically CI builds currently don't have COLLECT_KERNEL_DEBUG config option enabled.

So lets try to prevent those regressions in the future by aligning the CI build process with the build config options used later on the buildbots.

References: 066b0fee7668 ("kernel: copy only *.ko for debug info") References: https://github.com/openwrt/openwrt/pull/14218

Just quickly drafted to start discussion about the improvements, so untested as well...

Ansuel commented 6 months ago

@ynezz any reason why they are not part of the CONFIG_BUILDBOT option?

ynezz commented 6 months ago

@ynezz any reason why they are not part of the CONFIG_BUILDBOT option?

Uh, they're part of CONFIG_BUILDBOT option, but we're not setting it on the CI for some reason (another such regression).

Ansuel commented 6 months ago

@ynezz guess the problem is for kernel build where we would build way too much packages. Should we introduce the CONFIG_CI option?

ynezz commented 6 months ago

@ynezz guess the problem is for kernel build where we would build way too much packages.

Check the diff, I've tried to split it into multiple cheap/expensive parts and tried to enable the expensive parts only where it makes sense.

Should we introduce the CONFIG_CI option?

I would just try to keep the buildbot settings with CI somehow in the sync manually, when we find out buildbot failure like in this case, just enable the test case on the CI, IMO no need to complicate it with some other config option, looks like overkill to me.

aparcar commented 3 months ago

I think this looks good