search

openwrt / luci

LuCI - OpenWrt Configuration Interface
Apache License 2.0
6.38k stars 2.53k forks source link

Status > Overview > Network showing two ipv6 info boxes in 19.07.0-rc1 (Material theme) #3282

Closed CaboBeach closed 5 years ago

CaboBeach commented 5 years ago

I'm not sure if this is a bug, but i've only seen one ipv6 info box in this section in the past, the two that are showing in 19.07.0-rc1 both show the same info -

Screenshot from 2019-11-08 23-17-20

jeolives commented 5 years ago

Looks like you're using luci-theme-material. The introduction of https://github.com/openwrt/luci/commit/6ee61230616245baac02bba903266c881d216008 probably did this. https://github.com/openwrt/luci/commit/1116575513d4874693f56453034e25edcbb4ce1f also needs to be adopted luci-theme-material.

Specifically:

.network-status-table .ifacebox-body .ifacebadge > span {
    overflow: hidden;
    text-overflow: ellipsis;
CaboBeach commented 5 years ago

Thanks @jeolives , yes, i'm using luci-theme-material, sorry to ask, but would you happen to know what file 1116575 should be applied to, find / -name gives these results for cascade.css - 

/overlay/upper/www/luci-static/rosy/cascade.css
/overlay/upper/www/luci-static/material/cascade.css
find: /proc/9500: No such file or directory
/rom/www/luci-static/bootstrap/cascade.css
/www/luci-static/bootstrap/cascade.css
/www/luci-static/rosy/cascade.css
/www/luci-static/material/cascade.css

I assumed it would be /www/luci-static/bootstrap/cascade.css but looking at it just gives a wall of text and i'm not sure how to find the lines i need if that's the right file.

hnyman commented 5 years ago

what file 1116575 should be applied to, ... I assumed it would be /www/luci-static/bootstrap/cascade.css

Why would you patch the css file for the already fixed "bootstrap" theme, when you aim to fix Material theme? You need to fix /www/luci-static/material/cascade.css

(Regarding your files found, /rom is really the ROM (the flashed firmware) and the /overlay contains all later changes. Just patch /www/luci-static/material/cascade.css and those changes will also be visible as /overlay/www/luci-static/material/cascade.css )

jow- commented 5 years ago

Already fixed with https://github.com/openwrt/luci/commit/a8a76978298ba1cfddadbb48da73fa2abde82692, will be part of rc2.