search

openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.95k stars 3.46k forks source link

v2raya: should not be forced to depend on `xray-core` now #21450

Closed SpriteOvO closed 1 year ago

SpriteOvO commented 1 year ago

Maintainer: @1715173329

Description:

Since v2ray-core package has been added in PR #19327, and both v2ray-core and xray-core can be used as a dependency of v2raya, for now, I think v2raya should not be forced to depend on xray-core.

I'm not sure if opkg has a mechanism for optional dependencies, however, I think there should be a way to let users to determine which -core package to be installed only and used.

BTW, the blue notice in the doc of v2raya is outdated and need to be updated as well.

1715173329 commented 1 year ago

I'm not sure if opkg has a mechanism for optional dependencies

it's quite limited by opkg, and i dont wanna add dirty trick to work around.

well, i dont see much reason to use v2ray over xray. in v2raya none of new transports are supported yet, but for uot, xray's xudp implementation is much popular (widely used) than v2fly's packetaddr, this is the main reason i choose xray for dependency. v2raya also perfers xray now.

if you like v2ray you may install v2raya with addtional argument --nodeps (Do not follow dependencies).

BTW, the blue notice in the doc of v2raya is outdated and need to be updated as well.

yep, it's totally outdated. though i dont maintain this doc i may probably update it in the next few days (i'm busy now).

1715173329 commented 1 year ago

i've updated that doc, let's close it for now