openyurtio / raven

provide layer 3 and layer 7 network connectivity among pods in different physical regions
Apache License 2.0
57 stars 37 forks source link

Fix: raven traffic ignore nat #131

Closed YTGhost closed 1 year ago

YTGhost commented 1 year ago

Fixes #124

codecov[bot] commented 1 year ago

Codecov Report

Merging #131 (dc359e5) into main (5e8937d) will decrease coverage by 0.04%. Report is 1 commits behind head on main. The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   42.73%   42.69%   -0.04%     
==========================================
  Files           7        7              
  Lines        1053     1089      +36     
==========================================
+ Hits          450      465      +15     
- Misses        513      534      +21     
  Partials       90       90              
Flag Coverage Δ
unittests 42.69% <30.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/networkengine/routedriver/vxlan/vxlan.go 57.94% <ø> (+2.53%) :arrow_up:
pkg/networkengine/vpndriver/libreswan/libreswan.go 45.71% <30.00%> (-3.62%) :arrow_down:
YTGhost commented 1 year ago

@njucjc PTAL

njucjc commented 1 year ago

LGTM

YTGhost commented 1 year ago

@BSWANG This pr still needs some modifications based on our last discussion.

rambohe-ch commented 1 year ago

@YTGhost It seems that unit tests is not enough, please fix it.