openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

remove all_in_one.yaml #119

Closed YTGhost closed 2 years ago

YTGhost commented 2 years ago

Signed-off-by: HIHIA 283304489@qq.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

remove all_in_one.yaml

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot commented 2 years ago

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openyurtio/yurt-app-manager/pull/119): >Signed-off-by: HIHIA <283304489@qq.com> > > > > >#### What type of PR is this? >> /kind documentation > > > >#### What this PR does / why we need it: >remove all_in_one.yaml > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 2 years ago

Codecov Report

Merging #119 (09f12fb) into master (dfea469) will decrease coverage by 0.06%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   37.37%   37.31%   -0.07%     
==========================================
  Files          42       42              
  Lines        4776     4776              
==========================================
- Hits         1785     1782       -3     
- Misses       2752     2754       +2     
- Partials      239      240       +1     
Flag Coverage Δ
unittests 37.31% <ø> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...manager/controller/nodepool/nodepool_controller.go 56.75% <0.00%> (-1.02%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

zzguang commented 2 years ago

/lgtm

zzguang commented 2 years ago

/approve

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YTGhost, zzguang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [zzguang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment