search

openzim / mindtouch

libretexts.org to ZIM scraper
GNU General Public License v3.0
0 stars 0 forks source link

Apply proper CSS for proper page display - step 2 #30

Closed benoit74 closed 1 week ago

benoit74 commented 2 weeks ago

Fix #8

Second and final step of CSS retrieval and application: add inline CSS.

Mostly straightforward in fact, only concern was that CSS processor was not resilient to CSS parsing error, while it is quite easy to include at mostly no cost. Now done.

To be reviewed after https://github.com/openzim/libretexts/pull/29

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.37%. Comparing base (152e8b7) to head (738aa31). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/libretexts2zim/client.py 60.00% 2 Missing :warning:
scraper/src/libretexts2zim/processor.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30 +/- ## ========================================== - Coverage 51.48% 51.37% -0.12% ========================================== Files 9 9 Lines 540 547 +7 Branches 61 61 ========================================== + Hits 278 281 +3 - Misses 258 262 +4 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.