Closed benoit74 closed 4 days ago
Attention: Patch coverage is 13.23529%
with 118 lines
in your changes missing coverage. Please review.
Project coverage is 43.14%. Comparing base (
5236501
) to head (ad99067
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
For the record, I abused the dev
Docker image by building from this branch as well, just to be able to run the scraper asap in Zimfarm, since we did not release 0.1, who cares
I've opened https://github.com/openzim/mindtouch/issues/91 for the Exception
, there are many more than the ones you're mentioning here. But good point indeed
Fix #74 Fix #76 Fix #77 (and glossary had the same problem)
Workaround for #71 (real solution postponed to "later") and many other likely situations where we encounter an "unknown" src/href/srcset (inline JS and CSS, ...)
Changes: see list of commits
Some remarks:
--html-issues-warn-only
because now we do not have such issues anymore, we are always just logging a warning because these issues are here to stay and we do not want to fail the scrape just for few isolated issues (they are really isolated from test scrape which ran last days)