openzim / nautilus-webui

SaaS Web UI for nautilus
GNU General Public License v3.0
2 stars 0 forks source link

Add S3 uploading #49

Closed FledgeXu closed 1 year ago

FledgeXu commented 1 year ago

Goal

The goal of this PR is to add S3 uploading files support.

Abstract

rgaudin commented 1 year ago

Please don't push changes while in review

FledgeXu commented 1 year ago

My bad, I forgot to push yesterday ......

FledgeXu commented 1 year ago

Also please silence Codefactor as those are false positive (s3_key doesnt include user-provided data). I wonder if this is triggered by the variable name

I'm not quite sure how to please CodeFactor, do I need to change the function name?

For some reason, some times one of the dragged files is marked as successful in the UI while it hasn't been uploaded.

This may be caused by the frontend FileStatus and the backend is not synchronized, I need to update the frontend FileStatus and FileStatus related code

ValueError: File not found: 498aa35e-39a8-41d7-887d-240695a1de7e

I haven't encountered the error you mentioned, it looks like it's related to the connection of database?