search

openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

Segment title is shown when it should not #81

Closed Popolechien closed 4 years ago

Popolechien commented 4 years ago

In https://mooc.phzh.ch/ ZIM at each step the step number is indicated (with an extra large padding)

Capture d’écran 2020-07-20 à 11 27 54

This Step number and padding do not appear in the original version:

Capture d’écran 2020-07-20 à 11 29 09

satyamtg commented 4 years ago

This is rather a thing which we shall make optional as there are instances like edX which have this heading outside the vertical content block. So, it seems that we shall add a new boolean parameter, say --page-titles which would be passed to the scraper while running. What do you think @Popolechien @rgaudin ?

Popolechien commented 4 years ago

Well I have no preference but for the fact that when this section title is added there's also a bunch of blank space around it that is rather... unsightly.

rgaudin commented 4 years ago

Also think we could make the style of that title less space consuming and that would save us the complexity of a parameter for this.

satyamtg commented 4 years ago

Also think we could make the style of that title less space consuming and that would save us the complexity of a parameter for this.

After the CSS and JS changes, right now the title looks something like this - Screenshot from 2020-08-05 14-30-39

@rgaudin @Popolechien do we still want to change the appearance or leave it like that? (Apparently that space was due to the CSS and JS not applied properly)

rgaudin commented 4 years ago

OK for me

Popolechien commented 4 years ago

Looks good enough to me.

satyamtg commented 4 years ago

I think we can close this then.