search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
20 stars 18 forks source link

Set default timeout in `download.stream_file` to 10 seconds, and allow to override value #222

Open benoit74 opened 22 hours ago

benoit74 commented 22 hours ago

We never passed a timeout to these requests call, but obviously we should have (this seems to be the explanation to https://github.com/openzim/mindtouch/issues/80 so far)

codecov[bot] commented 22 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5f92462) to head (7ddea55).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 38 38 Lines 2224 2226 +2 Branches 426 426 ========================================= + Hits 2224 2226 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: