search

openzim / sotoki

StackExchange websites to ZIM scraper
https://library.kiwix.org/?category=stack_exchange
GNU General Public License v3.0
217 stars 25 forks source link

Move from multiple `--tag` flags to one single `--tags` flag #315

Open benoit74 opened 4 months ago

benoit74 commented 4 months ago

Currently, when the user wants to specify multiple ZIM tags, he has to specify multiple time the --tag parameter like in sotoki --tag "Quality Assurance" --tag "Another TAG"

This kind of this is not supported by the Zimfarm and is not in line with other scrapers behavior.

We hence want to move to one single --tags flag which might contain a CSV value like in sotoki --tags "Quality Assurance,Another TAG". Commas are not expected to be used in tag values.

NOTA: this is a breaking API change ... but I'm not sure this is really widely used anyway, so I suggest to still make it into 2.2.0 (instead of creating a 3.0.0).

rgaudin commented 4 months ago

As much as I don't like it, we made a promise in CHANGELOG that we'd respect semantic versioning so 3.0.0

rgaudin commented 4 months ago

Please don't use CSV, we already have ; separated in the ZIM. Makes more sense to use the same format.

benoit74 commented 4 months ago

OK, let's go for 3.0.0 and ; then 😉