search

openzim / zim-requests

Want a new ZIM file? Propose ZIM content improvements or fixes? Here you are!
https://farm.openzim.org
42 stars 3 forks source link

Zimit 2 tests: 100rabbits #1011

Open benoit74 opened 6 months ago

benoit74 commented 6 months ago

A new Zimit2 ZIM is ready for testing (really ready this time, I hope at least ^^)

Scraper: warc2zim 2.0.0-dev8 + zimit 2.0.0-dev5 + Browsertrix crawler 1.1.3 ZIM: https://mirror.download.kiwix.org/zim/.hidden/dev/100rabbits_en_2024-05.zim Library link: https://dev.library.kiwix.org/viewer#100rabbits_en_2024-05/

Suggested test plan:

@Jaifroid I can't assign you since you've never contributed to this repo, but you are more than welcomed to test as well ^^

Jaifroid commented 6 months ago

Thanks, @benoit74, I'll test on PWA and Browser Extension.

Popolechien commented 6 months ago

@benoit74 I think you got the library link wrong (it's mesquartierschinois instead of 100 rabbits)

Popolechien commented 6 months ago

Tested on macOS, works like a charm. Works also on Android (3.10.1) but not the Orca video (I get a black screen).

benoit74 commented 6 months ago

@benoit74 I think you got the library link wrong (it's mesquartierschinois instead of 100 rabbits)

Yup, fixed library link.

Works also on Android (3.10.1) but not the Orca video (I get a black screen).

😫

Jaifroid commented 6 months ago

Orca video is broken on Chromium browsers, even in Kiwix Serve and in the PWA. It works in Firefox.

Go to this page in a Chromium browser: https://dev.library.kiwix.org/viewer#100rabbits_en_2024-05/100r.co/site/orca.html . Same for the video on the DotGrid page: https://dev.library.kiwix.org/viewer#100rabbits_en_2024-05/100r.co/site/dotgrid.html.

Tested on Chrome and Edge for Windows. Works on Firefox for Windows.

I re-tested 100rabbits_en_2024-02.zim for comparison, and the videos work on Chromium browsers there, so this appears to be a regression with this test ZIM. 🤔🥲 (Sorry...)

Screenshot of the issue and the error message (in Wombat) on Kiwix JS Browser Extension:

image

Jaifroid commented 6 months ago

On the positive side, everything else seems to work well! 💐

Jaifroid commented 6 months ago

Further info: the video works in the Firefox PWA on Android, but not in the Chrome (system) browser PWA. This confirms it's not an Android issue at all, but a specific issue with the rewriting in Chromium browsers across all platforms (I suppose, at least Windows and Android). (I also added a screenshot of the error shown in console in comment above).

benoit74 commented 6 months ago

Thank you all! It's quite positive the issue is reproducible on probably all Chromium browsers, it means it is not tight to a specific mobile device reader AND much easier to debug on my machine ^^ Might be related to some recent YouTube change in the player to optimize something on Chromium

benoit74 commented 6 months ago

Issue and fix found ... quite weird indeed but 🤷🏻

benoit74 commented 6 months ago

I've just uploaded a new version of the ZIM, supposed to repair broken stuff. Same links.

As far as I can tell, it still has an issue with Kiwix Android but seems to now work on all Chromium-based readers. Could you please all confirm?

Popolechien commented 6 months ago

MacOS and Kiwix-JS Chrome are ok!

Jaifroid commented 6 months ago

I additionally confirm that video (both Orca and Dotgrid) is now working in:

In PWA on iPad and PWA on iPhone (Safari), the Orca video isn't working. If it's working in the iOS app but not in Safari, then that's a bit puzzling, given that mesquartierschinois was displaying similar video issues on iOS app and PWA. Should perhaps be double-checked that mesquartierschinois video is not working on the iOS app.

benoit74 commented 6 months ago

In PWA on iPad and PWA on iPhone (Safari), the Orca video isn't working.

This is a PWA on Safari issue for me. Triggered by Youtube player in zimit2 ZIM, but this is a "detail". See https://github.com/kiwix/kiwix-js/issues/1256 again

Jaifroid commented 6 months ago

This is a PWA on Safari issue for me. Triggered by Youtube player in zimit2 ZIM, but this is a "detail". See kiwix/kiwix-js#1256 again

I confirm. The good thing to know is that video does work on iOS (iPad and iPhone) when the ZIM is served from Kiwix Serve. That's great news for Zimit 2 overall!