search

openzipkin / brave

Java distributed tracing implementation compatible with Zipkin backend services.
Apache License 2.0
2.36k stars 713 forks source link

Consolidates notes on "extra" data #1424

Closed codefromthecrypt closed 6 months ago

codefromthecrypt commented 6 months ago

Before this change, notes about state, particularly the "one instance per plugin" rule were not consolidated on the method that can cause problems addExtra. This migrates notes together with additional warnings that when we talk about this being used for propagation plugins, we also mean not for ad-hoc usage, as that can lead to excessive overhead.

See #1421

codefromthecrypt commented 6 months ago

thanks for the look @reta!