Tests with Jenkins - Githubissues

openzipkin / zipkin-api

Zipkin's language independent model and HTTP Api Definitions

https://zipkin.io/zipkin-api/

Apache License 2.0

59 stars 32 forks source link

Closed jeqo closed 5 years ago

jeqo commented 5 years ago

Fixes #67

codefromthecrypt commented 5 years ago

might be more direct to run the tests directly (ie not maven) but I think considering we are already using maven to publish a snapshot, sgtm.

verified the build output included passing tests.

jeqo commented 5 years ago

@adriancole yes, I tried running nodejs directly first, but I wasn't able to find it (probably not installed on jenkins?) https://builds.apache.org/job/incubator-zipkin-api/job/jenkins-test/1/console

codefromthecrypt commented 5 years ago

I would have done the same as you.. progress not perfection :)