search

openzipkin / zipkin-js

Zipkin instrumentation for Node.js and browsers
Apache License 2.0
564 stars 171 forks source link

dockerize integration tests for memcached, redis and postgres #402

Open codefromthecrypt opened 5 years ago

codefromthecrypt commented 5 years ago

Right now, developers on all platforms and also CI needs to be aware of memcached, redis and postgres. They also need to be aware of docker, which is used to manage kafka. I'd suggest using docker for managing memcached, redis and postgres so folks only have one thing to be concerned with.

See #401

jcchavezs commented 5 years ago

Agree, env for integration tests should be portable. Tho, in my experience, running them in docker are always flaky so we should provide wait commands until everything is spinned up.

man. 8. jul. 2019, 03:41 skrev Adrian Cole notifications@github.com:

Right now, developers on all platforms and also CI needs to be aware of memcached, redis and postgres. They also need to be aware of docker, which is used to manage kafka. I'd suggest using docker for managing memcached, redis and postgres so folks only have one thing to be concerned with.

See #401 https://github.com/openzipkin/zipkin-js/pull/401

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-js/issues/402?email_source=notifications&email_token=AAXOYASXVFVUJIKLC4ZPZOTP6KELRA5CNFSM4H6W7NQKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5XQMLQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXOYASEIY2ENXAGXXVQXXTP6KELRANCNFSM4H6W7NQA .

eirslett commented 5 years ago

Relevant: https://github.com/testcontainers/testcontainers-node

codefromthecrypt commented 5 years ago

yep good point @jcchavezs and @eirslett, we've had good luck with testcontainers in java and it has a wait strategy we can use for containers listen ports