search

openzipkin / zipkin

Zipkin is a distributed tracing system
https://zipkin.io/
Apache License 2.0
17.02k stars 3.09k forks source link

Fix UiConfig test #3729

Closed anuraaga closed 9 months ago

anuraaga commented 9 months ago

Fixes #3724

The key point was to replace fetch-mock, which works with jest, with vitest mocking. But I also found combining the two tests into one to be easier to reason about (and debug until the finish).

I ran npm i to update lockfile after removing fetch-mock but it seems to have had a very dramatic effect, hope it didn't bring back any CVEs but not sure how to do better...

codefromthecrypt commented 9 months ago

pushed a commit as a couple other tests were still fetch'n

codefromthecrypt commented 9 months ago

thanks again @anuraaga !