openzipkin / zipkin

Zipkin is a distributed tracing system
https://zipkin.io/
Apache License 2.0
17.02k stars 3.09k forks source link

benchmarks: moves dependency scope to test except wire #3756

Closed codefromthecrypt closed 7 months ago

codefromthecrypt commented 7 months ago

same as https://github.com/openzipkin/brave/pull/1422 except...

ran server benchmarks just to make sure:

2024-04-12 13:47:32:209 [testcontainers-lifecycle-1] WARN tc.quay.io/dim/wrk:stable - The architecture 'amd64' for image 'quay.io/dim/wrk:stable' (ID sha256:11fb87b1ef9581f3a443395ab0080842170e66f195a1f63cfbc15b83822b2af6) does not match the Docker server architecture 'arm64'. This will cause the container to execute much more slowly due to emulation and may lead to timeout failures.
Benchmark started.
Container ghcr.io/openzipkin/java:21.0.2_p13 ports exposed at {9411=http://192.168.106.2:32932}
Container ghcr.io/openzipkin/zipkin-elasticsearch7:3.1.1 ports exposed at {9200=http://192.168.106.2:32927}
Container ghcr.io/openzipkin/brave-example:armeria ports exposed at {9000=http://192.168.106.2:32928}
Container ghcr.io/openzipkin/brave-example:armeria ports exposed at {8081=http://192.168.106.2:32931}
Container quay.io/prometheus/prometheus:v2.48.0 ports exposed at {9090=http://192.168.106.2:32930}
Container quay.io/giantswarm/grafana:7.5.4 ports exposed at {3000=http://192.168.106.2:32929}
--snip--
codefromthecrypt commented 7 months ago

trivy repo . --scanners vuln doesn't show benchmarks in it

codefromthecrypt commented 7 months ago

lint is broken due to this: https://github.com/openzipkin/zipkin/pull/3757