openzklib / openzl

Zero-Knowledge Cryptography Infrastructure Stack
https://openzl.org
Other
126 stars 14 forks source link

Linear Algebra #41

Open GhostOfGauss opened 1 year ago

GhostOfGauss commented 1 year ago

We implement some purely LA operations in openzl-crypto::poseidon::matrix and it would be good to move these to their own LA module or import a LA library.

Would such an import be a "plugin"?

GhostOfGauss commented 1 year ago

The tests of those LA operations defined in openzl_crypto::poseidon::matrix are currently in plugins::arkworks::poseidon::test because they were written using arkworks types. Those need to be moved too.

Also those are the reason why SquareMatrix::new_unchecked is pub instead of just pub(crate)