opera-adt / COMPASS

COregistered Multi-temPorAl Sar Slc
Apache License 2.0
38 stars 18 forks source link

[Bug]: `nodata`/`_FillValue` value is not being set in output products #139

Open scottstanie opened 1 year ago

scottstanie commented 1 year ago

Checked for duplicates

Yes - I've already checked

Describe the bug

When plotting the static layers, I noticed that the empty region was 0s instead of nan like it is for the CSLCs.

What did you expect?

I expected

  1. the nodata to be nan like the CSLC, or
  2. to have it marked in the metadata

even if we change (1) to match, we should still mark it in all output files

Reproducible steps

(mapping) [staniewi@aurora gslcs]$ rio info --nodata NETCDF:t071_151204_iw1_20190704.h5:/science/SENTINEL1/CSLC/grids/VV

(mapping) [staniewi@aurora gslcs]$ rio info --nodata NETCDF:static_layers_t071_151204_iw1.h5:/science/SENTINEL1/CSLC/grids/static_layers/heading
scottstanie commented 1 year ago

Adding the docs on missing data for CF Conventions: http://cfconventions.org/cf-conventions/cf-conventions.html#missing-data

vbrancat commented 1 year ago

This should be addressed by #167