search

operantnetworks / ndn-ind

Named Data Networking libraries to support industrial applications
Other
2 stars 2 forks source link

PSync: Compute murmurhash using name TLV, not URI. #59

Open jefft0 opened 2 years ago

jefft0 commented 2 years ago

As explained in this issue in the original PSync project, when PSync computes a murmurhash on an NDN name, it currently uses the name URI string. But there are multiple ways to display the URI string and it is not guaranteed to be unique. Instead, the TLV encoding should be used.

The original PSync code has been updated in commit https://github.com/named-data/PSync/commit/32ccfc4d1d4db648763bf96ffdf8ac87f0bc3f50 . Similar changes should be made to this library where it calls murmurHash3 on an NDN name. As mentioned in the commit, this is a breaking change. The code used by all PSync participants would need to be updated.

yoursunny commented 2 years ago

I'd suggest wait a bit until I resolve PSync issue 4818, which may involve switching to a different hash function.

jefft0 commented 2 years ago

OK. Thank you.