operator-framework / catalogd

On-cluster FBC catalog content server
Apache License 2.0
16 stars 32 forks source link

🌱 bump ginkgo to 2.21.0 #456

Closed grokspawn closed 2 weeks ago

grokspawn commented 2 weeks ago

This bumps ginkgo to 2.21.0 since dependabot does not bump go.mod and .bingo/* dependencies in the same PR.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.23%. Comparing base (f279c4c) to head (9d9c45c). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #456 +/- ## ======================================= Coverage 38.23% 38.23% ======================================= Files 15 15 Lines 1224 1224 ======================================= Hits 468 468 Misses 706 706 Partials 50 50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

camilamacedo86 commented 2 weeks ago

/lgtm cancel /approve cancel

@grokspawn

It seems that we have an issue to build it

Run hack/scripts/check-go-version.sh "4d6327f8d20e6a22c310b8ccae69e2eec63bd0a7" Found golang version: 1.22.5 ./.bingo/go.mod: Skipping, no version found ./.bingo/ginkgo.mod: 1.22.0: Updated golang version from 1.22 Error: Process completed with exit code 1.

See the CI: https://github.com/operator-framework/catalogd/actions/runs/11806891013/job/32892465153?pr=456

camilamacedo86 commented 2 weeks ago

/approve cancel

grokspawn commented 2 weeks ago

/lgtm cancel /approve cancel

@grokspawn

It seems that we have an issue to build it

Run hack/scripts/check-go-version.sh "4d6327f8d20e6a22c310b8ccae69e2eec63bd0a7" Found golang version: 1.22.5 ./.bingo/go.mod: Skipping, no version found ./.bingo/ginkgo.mod: 1.22.0: Updated golang version from 1.22 Error: Process completed with exit code 1.

See the CI: https://github.com/operator-framework/catalogd/actions/runs/11806891013/job/32892465153?pr=456

This is not required CI, and it looks like the script isn't happy about how bingo represented the go version with the third octet (1.22.0) whereas that is correct. But there's no actual error here.

grokspawn commented 2 weeks ago

go-verdiff fixed by #458