operator-framework / deppy

Deppy: The dependency resolver for Kubernetes
Apache License 2.0
14 stars 21 forks source link

🌱 Update the internal solver before exporting #164

Closed m1kola closed 5 months ago

m1kola commented 5 months ago

Related to #161

Preparing the internal solver to be exported and used without the DeppySolver wrapper.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e676cce) 63.90% compared to head (13066d1) 64.43%.

Files Patch % Lines
internal/solver/solve.go 93.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #164 +/- ## ========================================== + Coverage 63.90% 64.43% +0.53% ========================================== Files 11 11 Lines 482 478 -4 ========================================== Hits 308 308 + Misses 155 152 -3 + Partials 19 18 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ncdc commented 5 months ago

This PR is definitely a step in the right direction. We can resolve whether to use a context or not later.