operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
76 stars 54 forks source link

Docs: Collapsible admonitions that start collapsed should be more accessible #1479

Open trgeiger opened 1 week ago

trgeiger commented 1 week ago

For longer file examples or command outputs, we currently use several collapsible admonition blocks on our docs site. It's not immediately obvious that these are expandable without some textual indication.

To improve accessibility and the general UX of the docs, we should add some indication that these are expandable to the admonition titles, or perhaps consider having all collapsible blocks start expanded.

m1kola commented 5 days ago

I'm not an accessibility expert at all, but I checked with VoiceOver and it announces when you reach an expandable block and suggests how to expand or collapse it. I'm not sure if overall screen reader accessibility of the docs website is good enough. To improve accesibility we will likely have to contribute to mkdocs-material.

But I agree - even visually these blocks are not very intuitive. I do not have objections to either make them expanded by default or convert them non-collapsible admonitions.

trgeiger commented 5 days ago

Yeah I've been meaning to do a general once-over for general accessibility issues. I should probably make a main issue with subissues or something once I do that. This one example of the expandable admonitions just came up for me when I was doing some of the other docs stuff. Testing the screenreader is good, but I think this is also a more general UX issue since the admonitions aren't obviously expandable when they start closed.