search

opf / helm-charts

OPF helm chart repository
https://charts.openproject.org
GNU General Public License v3.0
11 stars 20 forks source link

adds readiness and liveness probes to the worker process #85

Open machisuji opened 6 months ago

machisuji commented 6 months ago

Depends on https://github.com/opf/openproject/pull/14625

I'm not sure how much sense it makes to add a readiness probe to the worker as that usually controls if traffic is routed to a container which does not apply in this case.

As for the liveness probe the question is how to do it. If the container is running then it will work off jobs. It's unlikely for the container to get stuck not doing anything. In that case it would probably just crash and be restarted anyway.

With the current liveness probe which is checked for unprocessed delayed jobs it might therefore not help to restart the containers if jobs start piling up. It might just be that there are not enough workers.

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: 00a3cc1f5df5e75541aad2233d39ad34f43521da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

oliverguenther commented 1 week ago

we should adapt this to https://github.com/bensheldon/good_job?tab=readme-ov-file#cli-http-health-check-probes now.