opiproject / ansible-opi-dpu

Ansible Modules for DPUs
Apache License 2.0
6 stars 8 forks source link

Split req.txt into req-dev.txt for development dependencies (#44) #90

Open MAVRICK-1 opened 2 months ago

MAVRICK-1 commented 2 months ago

Fixes #44

@glimchb can you review my PR

glimchb commented 2 months ago

@MAVRICK-1 is the split correct? All build/test packages now in dev req txt ?

MAVRICK-1 commented 2 months ago

@glimchb sry my mistake This will be requirements-dev.txt

ansible-lint>=6.22.2
antsibull-changelog>=0.25.0
antsibull-docs>=2.7.0

And this will be requirements.txt

python-dateutil>=2.8.2
MAVRICK-1 commented 2 months ago

@glimchb

glimchb commented 2 months ago

try to find existing examples how this should work properly... for example https://github.com/PaloAltoNetworks/ansible-playbooks/blob/master/dev-requirements.txt

MAVRICK-1 commented 1 month ago

@glimchb now it is okay ?

glimchb commented 1 month ago

@glimchb now it is okay ?

much better

glimchb commented 1 month ago

solves #44

btw, solves #44 is not recognized by GitHub

try Fixes #44

MAVRICK-1 commented 1 month ago

@glimchb Docker CLI FAIL HAS BEEN RESOLVED

MAVRICK-1 commented 1 month ago

@glimchb done

glimchb commented 1 month ago

@glimchb done

looks good, please rebase. I fixed ci, so it will pass now

MAVRICK-1 commented 1 month ago

@glimchb rebase done

glimchb commented 1 month ago

@glimchb rebase done

Looks like ci passes!!!

last thing: Can you squash all commits to single ine so we have bice liner history, please ?

MAVRICK-1 commented 1 month ago

@glimchb done 👍