opnsense / core

OPNsense GUI, API and systems backend
https://opnsense.org/
BSD 2-Clause "Simplified" License
3.28k stars 727 forks source link

reporting: Unbound DNS database backup can take up a lot of storage space -- delete after restore? #7494

Open fichtner opened 4 months ago

fichtner commented 4 months ago

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

https://forum.opnsense.org/index.php?topic=40621.0

The database export can leave excessively large files on the disk and it is not removed after a (successful) restore operation.

To Reproduce

Record a lot of queries... but in general any major upgrade will leave the full backup under /var/cache/unbound.duckdb regardless of its size.

Expected behavior

Clear the backup in the good recovery case perhaps. Maybe also drop the backup location when resetting the database from the GUI action.

Describe alternatives you considered

N/A

Screenshots

N/A

Relevant log files

N/A

Additional context

N/A

Environment

Any recent version with a major upgrade done and the database active.

fichtner commented 3 months ago

As fate will have it DuckDB 1.0.0 is out without further breakage to existing databases. It likely means we can retire the pre-upgrade hook as well.