mvc: $timestamp is undefined in getRevisionContext()

opnsense / core

OPNsense GUI, API and systems backend

https://opnsense.org/

BSD 2-Clause "Simplified" License

3.28k stars 727 forks source link

mvc: $timestamp is undefined in getRevisionContext() #7500

Closed fichtner closed 3 months ago

fichtner commented 3 months ago

As spotted by coverity... we could also ditch the condition but it looked like we could start passing the timestamp around, maybe even omitting the need for empty check since it's only called once?

fichtner commented 3 months ago

The offending line was this one:

https://github.com/opnsense/core/blob/6a541aff16cfce74882b702580eff832bb1e2159/src/opnsense/mvc/app/library/OPNsense/Core/Config.php#L489

AdSchellevis commented 3 months ago

@fichtner I think I rather ditch the parameter in this case. I'll do that later and close this PR, thanks!

fichtner commented 3 months ago

Ok 👍