opnsense / core

OPNsense GUI, API and systems backend
https://opnsense.org/
BSD 2-Clause "Simplified" License
3.38k stars 757 forks source link

CPU Temperature graphs not working in 24.7.7 #8023

Open awilkin87 opened 3 weeks ago

awilkin87 commented 3 weeks ago

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

After upgrading to 24.7.7, I found that the reporting graphs were not working. I reset the RRD data and restarted the system. The graphs re-populated, except for the cputemp graph.

After some troubleshooting, I tracked the issue to the recent RRD refactoring (https://github.com/opnsense/core/pull/7836). I found that the sysctl command to get CPU temps was returning an error. Also, the RRD filename is not defined in Types/Temperature.php.

To Reproduce

Steps to reproduce the behavior:

  1. Install OPNsense 24.7.6
  2. Ensure Thermal Sensors are configured correctly under System -> Settings -> Miscellaneous
  3. Ensure "Enables the RRD graphing backend" is checked under Reporting -> Settings.
  4. Ensure non-zero values are displayed in the System/Cputemp graph under Reporting -> Health.
  5. Upgrade to OPNsense 24.7.7
  6. Go to Reporting -> Settings
  7. Click "Reset RRD Data"
  8. Wait over 1 minute

Actual behavior

Expected behavior

Describe alternatives you considered

N/A

Screenshots

N/A

Relevant log files

N/A

Additional context

N/A

Environment

Software version used and hardware type if relevant, e.g.:

OPNsense 24.7.7 (amd64). Intel® Pentium® J3710 2.64Ghz Quad Core (using coretemp) Network Intel® I225-V

awilkin87 commented 3 weeks ago

I've submitted a pull request with a fix: https://github.com/opnsense/core/pull/8024