optuna / optuna-integration

Extended functionalities for Optuna in combination with third-party libraries.
https://optuna-integration.readthedocs.io/en/latest/index.html
MIT License
39 stars 30 forks source link

Align run name strategy between `MLflowCallback` and `track_in_mlflow` method #111

Closed TTRh closed 7 months ago

TTRh commented 7 months ago

Motivation

The strategy for infering the run name was not aligned between the base class MLflowCallback and the decorator track_in_mlflow.

Description of the changes

This PR aligned the strategy to get the run name from MLfowCallback and pass it to mlflow. We lookup _mlflow_kwargs and we fallback on trial.number if not given.

TTRh commented 7 months ago

Tests are failing but i'm not sure it's related to my change i see in the logs:

ERROR collecting tests/lightgbm_tuner_tests/test_alias.py
HideakiImamura commented 7 months ago

Sorry for the confusion. I will fix the main branch. Please wait a minuite.

HideakiImamura commented 7 months ago

The main branch has been fixed in https://github.com/optuna/optuna-integration/pull/112. Could you merge the main branch?

github-actions[bot] commented 7 months ago

This pull request has not seen any recent activity.