search

oracle / terraform-kubernetes-installer

Terraform Installer for Kubernetes on Oracle Cloud Infrastructure
Other
179 stars 118 forks source link

add support for multiple compartments as per sod #175

Open srirg opened 6 years ago

srirg commented 6 years ago

This PR is a fix for https://github.com/oracle/terraform-kubernetes-installer/issues/166

garthy commented 6 years ago

I'm not sure the multiple_compartments flag is needed. Can you just use the value if set? e.g:-

network_compartment_ocid = "${(var.network_compartment_ocid != "") ? var.network_compartment_ocid : var.compartment_ocid}"

Also can you rebase + squash to master and split the functionally out into a clean merge request with structured descriptive commit message(s). At the moment this change has many features including a bastion change with many unneeded commit messages.

Thanks