orange-cloudfoundry / terraform-provider-cloudfoundry

A terraform provider to manage a Cloud Foundry instance.
Apache License 2.0
31 stars 8 forks source link

Application Security Group : icmp rules are KO #2

Closed poblin-orange closed 7 years ago

poblin-orange commented 7 years ago

Tested with terraform cloudfoundry provider 0.8 / 0.5.4 I cant apply ASG icmp rules (cf 245). Here is the error i get

cloudfoundry_quota.tf_org_quota: Refreshing state... (ID: dcad5ab4-3dbe-4724-b602-83044b646831)                    
cloudfoundry_sec_group.sec_group_services-ping: Creating...                                                        
  name:                         "" => "services-ping"                                                              
  on_running:                   "" => "true"                                                                       
  on_staging:                   "" => "false"                                                                      
  rules.#:                      "" => "1"                                                                          
  rules.2387358670.code:        "" => "0"
  rules.2387358670.description: "" => "any ICMP to NET_CF_SERVICES"
  rules.2387358670.destination: "" => "192.168.30.0-255.255.255.0"
  rules.2387358670.log:         "" => "false"
  rules.2387358670.ports:       "" => ""
  rules.2387358670.protocol:    "" => "icmp"
  rules.2387358670.type:        "" => "0"
Error applying plan:

1 error(s) occurred:

* cloudfoundry_sec_group.sec_group_services-ping: Server error, status code: 400, error code: 300001, message: The security group is invalid: rules rule number 1 missing required field 'code', rules rule number 1 missing required field 'type'

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.
ArthurHlt commented 7 years ago

Fixed on commit: https://github.com/orange-cloudfoundry/terraform-provider-cloudfoundry/commit/3e1d2676be0046b6a574fca85cc1f608b0246a2a