orbeon / orbeon-forms

Orbeon Forms is an open source web forms solution. It includes an XForms engine, the Form Builder web-based form editor, and the Form Runner runtime.
http://www.orbeon.com/
GNU Lesser General Public License v2.1
514 stars 220 forks source link

"Session has expired" pasting form in Form Builder #1483

Open avernet opened 10 years ago

avernet commented 10 years ago

To reproduce – Paste the source of this form in Form Builder, scroll down to the control labeled Validation fail1, open the Control Settings for that control, click Apply, first an error shows, but after that Form Builder is unusable and every Ajax request gets an answer saying that the session has expired.

avernet commented 10 years ago

Is there a way for us to recover from the error in the xxf:dynamic? If there really is no way, can we consider the xxf:dynamic dead, but at least let users to "view source" and copy/paste the changes they have done so far to a temp file, or do a save if we don't want to disable that option?

ebruchez commented 10 years ago

I have some local experiments on 2014-03-11-handle-errors-in-xxf-dynamic. The idea is exactly that: to remove the xxf:dynamic content in case an error occurs.

avernet commented 9 years ago

+1 from customer

ebruchez commented 9 years ago

If an XPath exception on an xf:bind has a static XPath error, we get the same issue.

Note that can only happen if:

  1. The expression was changed by editing the source code, either in Form Builder or via the persistence API.
  2. Or a bug in Orbeon Forms changed that expression.

This particular case should ideally:

xxf:dynamic should be configurable so that such errors could be considered fatal. For Form Builder, they shouldn't be, but for other (future) uses of xxf:dynamic, they should be considered like top-level static errors.

ebruchez commented 9 years ago

Still the case with 4.9.