Run tests with go-ipfs - Githubissues

orbitdb-archive / ipfs-log

Append-only log CRDT on IPFS

https://orbitdb.github.io/ipfs-log/

MIT License

398 stars 55 forks source link

Run tests with go-ipfs #169

Closed haadcode closed 6 years ago

haadcode commented 6 years ago

This PR will add support running tests with go-ipfs.

Changes:

Add go-ipfs and ipfsd-ctl as dev dependencies
Remove obsolete "coverage" script from package.json
Copy go-ipfs test utility functions from orbit-db
Use datastore-level in test js-ipfs instances
Refactor tests to use both ipfs implementations
Add instructions to README

haadcode commented 6 years ago

I believe we're hitting the same bug with go-ipfs 0.4.17 (latest) as in https://github.com/orbitdb/orbit-db/pull/417 and the replication tests some times fail (in short: peers don't connect on pubsub level even though they're connected on peer-level, bug reported here https://github.com/libp2p/go-floodsub/issues/93).

With 0.4.10 the tests seem to run successfully.

haadcode commented 6 years ago

This seems to be fixed now with go-ipfs 0.4.17 (latest). The fix was to not connect peers manually before starting the tests and let go-ipfs handle it through peer discovery.

shamb0t commented 6 years ago

LGTM :tada: :smiley:

haadcode commented 6 years ago

Thanks 👍