orbitdb-archive / ipfs-log

Append-only log CRDT on IPFS
https://orbitdb.github.io/ipfs-log/
MIT License
398 stars 55 forks source link

Headless Chrome Tests #188

Closed aphelionz closed 6 years ago

aphelionz commented 6 years ago

Description

Branching from partway through https://github.com/orbitdb/ipfs-log/pull/186, this work continues the browser testing. I like the paradigm overall, using mocha-chrome-headless to run the tests. As the PR stands, it is a proof of concept using CircleCI to run the tests.

Resolves #41

TODO

Fix the replication tests

Scripts

Deps

New dependencies:

New dev dependencies:

haadcode commented 6 years ago

@aphelionz thanks for the PR and continuing the previous efforts! 👍

I spend some time today to look at the failing replication tests, but can't figure out what's going on. The short is, I'm seeing weird errors (not seen before) from ipfs/libp2p as I tested through the various config options. The same observations though, the peers can't connect.

I'd be happy to skip the replications tests in the browser for now in order to move this PR ahead. We'll need to solve the replication/connectivity problems for orbitdb browser tests too, so let's do that at the same time.

I rebased the branch on master and made a small change to make it explicit that we're skipping the replications tests (as opposed to not including them). Perhaps we should add a "if (isNode)" check to those tests to not skip them when running in nodejs?

aphelionz commented 6 years ago

@haadcode Just confirmed, tests passing with this merged into master. Review one last time and I'm ready to merge.

haadcode commented 6 years ago

Thanks for the PR @aphelionz! 👍