ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
327 stars 25 forks source link

chore: Move to booleans instead of ints, fixes #114 #118

Closed hassila closed 1 year ago

hassila commented 1 year ago

Description

Use proper typing for bools

Fixes #114

How Has This Been Tested?

Manual testing.

Minimal checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #118 (7657cdc) into main (5f4d832) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/ordo-one/package-benchmark/pull/118/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://codecov.io/gh/ordo-one/package-benchmark/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #118 +/- ## ======================================= Coverage 76.43% 76.43% ======================================= Files 22 22 Lines 2431 2431 ======================================= Hits 1858 1858 Misses 573 573 ``` ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/ordo-one/package-benchmark/pull/118?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/ordo-one/package-benchmark/pull/118?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [5f4d832...7657cdc](https://codecov.io/gh/ordo-one/package-benchmark/pull/118?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 1 year ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2023-03-21T11:00:47+00:00 Pull request had performance regressions