ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

chore(patch): [sc-2205] Stub out libproc.h on iOS #170

Closed axelandersson closed 1 year ago

axelandersson commented 1 year ago

Description

Use CDarwinOperatingSystemStats on iOS but stub out all uses of libproc.h. Let makeOperatingSystemStats() return at least information about number of threads.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #2205: Create iOS/iPad target and make it buildable.

codecov[bot] commented 1 year ago

Codecov Report

Merging #170 (faaaf64) into main (9cc05dc) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #170 +/- ## ======================================= Coverage 71.42% 71.42% ======================================= Files 26 26 Lines 3446 3446 ======================================= Hits 2461 2461 Misses 985 985 ``` | [Impacted Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Sources/Benchmark/Benchmark.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrLnN3aWZ0) | `72.34% <ø> (ø)` | | | [Impacted Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Sources/Benchmark/Benchmark.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrLnN3aWZ0) | `72.34% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [9cc05dc...faaaf64](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 1 year ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2023-07-05T07:34:04+00:00 Pull request had performance regressions