ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

fix(minor): Fix incorrect syscalls #187

Closed hassila closed 1 year ago

hassila commented 1 year ago

Description

Deducts the syscall overhead for cleaner statistics. Fix the broken API for setup closures.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

github-actions[bot] commented 1 year ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2023-09-14T09:49:58+00:00 Pull request had performance regressions

codecov[bot] commented 1 year ago

Codecov Report

Merging #187 (73f24f4) into main (1e3568b) will decrease coverage by 0.15%. The diff coverage is 51.35%.

:exclamation: Current head 73f24f4 differs from pull request most recent head d7b3cf5. Consider uploading reports for the commit d7b3cf5 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #187 +/- ## ========================================== - Coverage 71.14% 70.99% -0.15% ========================================== Files 29 29 Lines 3652 3671 +19 ========================================== + Hits 2598 2606 +8 - Misses 1054 1065 +11 ``` | [Files Changed](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [.../Benchmark/Benchmark+ConvenienceInitializers.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrK0NvbnZlbmllbmNlSW5pdGlhbGl6ZXJzLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [Sources/Benchmark/Benchmark.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrLnN3aWZ0) | `73.05% <ø> (ø)` | | | [Sources/Benchmark/BenchmarkExecutor.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrRXhlY3V0b3Iuc3dpZnQ=) | `93.77% <100.00%> (+0.16%)` | :arrow_up: | | [Sources/Benchmark/BenchmarkRunner.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrUnVubmVyLnN3aWZ0) | `59.09% <100.00%> (+0.10%)` | :arrow_up: | | [Files Changed](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [.../Benchmark/Benchmark+ConvenienceInitializers.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrK0NvbnZlbmllbmNlSW5pdGlhbGl6ZXJzLnN3aWZ0) | `0.00% <0.00%> (ø)` | | | [Sources/Benchmark/Benchmark.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrLnN3aWZ0) | `73.05% <ø> (ø)` | | | [Sources/Benchmark/BenchmarkExecutor.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrRXhlY3V0b3Iuc3dpZnQ=) | `93.77% <100.00%> (+0.16%)` | :arrow_up: | | [Sources/Benchmark/BenchmarkRunner.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrUnVubmVyLnN3aWZ0) | `59.09% <100.00%> (+0.10%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [1e3568b...d7b3cf5](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/187?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).