Closed hassila closed 10 months ago
Attention: 300 lines
in your changes are missing coverage. Please review.
Comparison is base (
2e724bf
) 70.40% compared to head (a470c6b
) 67.18%. Report is 2 commits behind head on main.
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-01-08T10:10:44+00:00 Pull request had performance regressions
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-01-08T10:13:46+00:00 Pull request had performance regressions
Description
Reduce dependencies from 12->7;
Removing extras-json and instead use Foundations JSON - we have a Foundation dependency anyway and will hopefully soon move to the new swift-foundation.
Fold in Progress.Swift inline with the project instead of depending on Ordo tagged release version
Fold in BenchmarkClock to remove dependency on Ordo package-datetime
Update NIO locks from upstream
Move Benchmarks to a separate embedded project a la SwiftNIO to allow it to use newer toolchain and remove dependencies
Remove DocC plugin dependency as it is done behind the scenes by SPI anyway
How Has This Been Tested?
Test suite and manually tested on macOS
Minimal checklist:
DocC
code-level documentation for any public interfaces exported by the package