ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

chore(minor): Reduce dependencies #215

Closed hassila closed 10 months ago

hassila commented 11 months ago

Description

Reduce dependencies from 12->7;

Removing extras-json and instead use Foundations JSON - we have a Foundation dependency anyway and will hopefully soon move to the new swift-foundation.

Fold in Progress.Swift inline with the project instead of depending on Ordo tagged release version

Fold in BenchmarkClock to remove dependency on Ordo package-datetime

Update NIO locks from upstream

Move Benchmarks to a separate embedded project a la SwiftNIO to allow it to use newer toolchain and remove dependencies

Remove DocC plugin dependency as it is done behind the scenes by SPI anyway

How Has This Been Tested?

Test suite and manually tested on macOS

Minimal checklist:

codecov[bot] commented 11 months ago

Codecov Report

Attention: 300 lines in your changes are missing coverage. Please review.

Comparison is base (2e724bf) 70.40% compared to head (a470c6b) 67.18%. Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #215 +/- ## ========================================== - Coverage 70.40% 67.18% -3.22% ========================================== Files 29 34 +5 Lines 3909 4376 +467 ========================================== + Hits 2752 2940 +188 - Misses 1157 1436 +279 ``` | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Benchmarks/Benchmarks/Histogram/Histogram.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-QmVuY2htYXJrcy9CZW5jaG1hcmtzL0hpc3RvZ3JhbS9IaXN0b2dyYW0uc3dpZnQ=) | `44.96% <ø> (ø)` | | | [Sources/Benchmark/BenchmarkExecutor.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrRXhlY3V0b3Iuc3dpZnQ=) | `91.67% <ø> (ø)` | | | [...ark/MallocStats/MallocStatsProducer+jemalloc.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvTWFsbG9jU3RhdHMvTWFsbG9jU3RhdHNQcm9kdWNlcitqZW1hbGxvYy5zd2lmdA==) | `50.57% <0.00%> (ø)` | | | [Sources/Benchmark/BenchmarkRunner+ReadWrite.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrUnVubmVyK1JlYWRXcml0ZS5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [Sources/Benchmark/Progress/ProgressElements.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvUHJvZ3Jlc3MvUHJvZ3Jlc3NFbGVtZW50cy5zd2lmdA==) | `92.42% <92.42%> (ø)` | | | [Sources/Benchmark/Progress/Utilities.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvUHJvZ3Jlc3MvVXRpbGl0aWVzLnN3aWZ0) | `59.52% <59.52%> (ø)` | | | [Sources/Benchmark/Progress/Progress.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvUHJvZ3Jlc3MvUHJvZ3Jlc3Muc3dpZnQ=) | `57.41% <57.41%> (ø)` | | | [...rces/Benchmark/NIOConcurrencyHelpers/NIOLock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvTklPQ29uY3VycmVuY3lIZWxwZXJzL05JT0xvY2suc3dpZnQ=) | `77.27% <77.27%> (ø)` | | | [Sources/Benchmark/BenchmarkClock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrQ2xvY2suc3dpZnQ=) | `33.72% <33.72%> (ø)` | | | [Sources/Benchmark/NIOConcurrencyHelpers/lock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvTklPQ29uY3VycmVuY3lIZWxwZXJzL2xvY2suc3dpZnQ=) | `1.75% <1.75%> (ø)` | | | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Benchmarks/Benchmarks/Histogram/Histogram.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-QmVuY2htYXJrcy9CZW5jaG1hcmtzL0hpc3RvZ3JhbS9IaXN0b2dyYW0uc3dpZnQ=) | `44.96% <ø> (ø)` | | | [Sources/Benchmark/BenchmarkExecutor.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrRXhlY3V0b3Iuc3dpZnQ=) | `91.67% <ø> (ø)` | | | [...ark/MallocStats/MallocStatsProducer+jemalloc.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvTWFsbG9jU3RhdHMvTWFsbG9jU3RhdHNQcm9kdWNlcitqZW1hbGxvYy5zd2lmdA==) | `50.57% <0.00%> (ø)` | | | [Sources/Benchmark/BenchmarkRunner+ReadWrite.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrUnVubmVyK1JlYWRXcml0ZS5zd2lmdA==) | `0.00% <0.00%> (ø)` | | | [Sources/Benchmark/Progress/ProgressElements.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvUHJvZ3Jlc3MvUHJvZ3Jlc3NFbGVtZW50cy5zd2lmdA==) | `92.42% <92.42%> (ø)` | | | [Sources/Benchmark/Progress/Utilities.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvUHJvZ3Jlc3MvVXRpbGl0aWVzLnN3aWZ0) | `59.52% <59.52%> (ø)` | | | [Sources/Benchmark/Progress/Progress.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvUHJvZ3Jlc3MvUHJvZ3Jlc3Muc3dpZnQ=) | `57.41% <57.41%> (ø)` | | | [...rces/Benchmark/NIOConcurrencyHelpers/NIOLock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvTklPQ29uY3VycmVuY3lIZWxwZXJzL05JT0xvY2suc3dpZnQ=) | `77.27% <77.27%> (ø)` | | | [Sources/Benchmark/BenchmarkClock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrQ2xvY2suc3dpZnQ=) | `33.72% <33.72%> (ø)` | | | [Sources/Benchmark/NIOConcurrencyHelpers/lock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvTklPQ29uY3VycmVuY3lIZWxwZXJzL2xvY2suc3dpZnQ=) | `1.75% <1.75%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [2e724bf...a470c6b](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 10 months ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-01-08T10:10:44+00:00 Pull request had performance regressions

github-actions[bot] commented 10 months ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-01-08T10:13:46+00:00 Pull request had performance regressions